Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Anchor Block Support and Vertical Alignment capability #23

Merged
merged 10 commits into from
Feb 11, 2022

Conversation

aurooba
Copy link
Member

@aurooba aurooba commented Feb 5, 2022

Closes #5

  • This PR adds anchor support to both Super List and Super List Item block.
  • There is also a slight visual adjustment to the Super List block inserter, to make it a little smaller but still obvious and easy to click on.
  • This PR also adds the Vertical Alignment capability to the overall super list. It does not as of yet, allow you to control vertical alignment on individual Super List Items – that would be part of a larger conversation connected to this comment about layout capabilities.

As far as the Vertical Alignment feature goes:

This is ready and I've done some preliminary testing. But it needs to be tested a bit more to ensure there won't be that Block Recovery error on existing super lists. I've set it up so that the justification settings only add classes IF a justification is set, so theoretically that means there should be no errors on past blocks that don't have anything set. But I'd like to test it a bit more before merging.

  • Test on online installations where I have the v0.1.0 installed to check if justification addition causes an error.

@aurooba aurooba merged commit 68a8f32 into main Feb 11, 2022
@aurooba aurooba deleted the enhance/block-supports branch February 11, 2022 20:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add justification settings
1 participant