Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add theme.json support #31

Merged
merged 13 commits into from
Feb 12, 2022
Merged

Add theme.json support #31

merged 13 commits into from
Feb 12, 2022

Conversation

aurooba
Copy link
Member

@aurooba aurooba commented Feb 12, 2022

Closes #8

This is a pretty awesome PR, even if I do say so myself. There are a few different things happening here:

  • I've added link color support to both blocks
  • the list-item width setting no longer sets explicit inline size, and rather modifies a CSS Custom Property inline instead
  • there is theme.json support for not only the list-item width setting, but for all the settings the block supports, so any theme can set their own defaults for the Super List block.
    • this includes smart support for the orientation setting! if theme.json sets a default for the list orientation, it will be respected. So if a theme primarily wants to use Super List in horizontal mode, they can set that as their default so they don't keep having to switch it in every new block.
  • we've also got a handy dandy theme.json example in the block itself to make life easier for theme authors

@aurooba aurooba merged commit f6e0aff into main Feb 12, 2022
@aurooba aurooba deleted the enhance/theme-json-support branch February 12, 2022 02:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add theme.json support
1 participant