Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix faulty background-size CSS style #6

Conversation

tuomohopia
Copy link

I think there's a typo in the CSS file that makes the file an invalid .css sheet.

This PR just changes $ to %.

@einazare
Copy link
Contributor

Hello @tuomohopia ,

We'll take a look at your PR in a couple of days. If it's ok, we'll add it to out dev-main branch.

Best,
Manu

@einazare
Copy link
Contributor

Hello again, @tuomohopia ,

We've checked your PR, and it is not quite ok. You've changed only the assets/styles/tailwind.css file. But you should also change the tailwind.config.js file as well at line 72.
When you're don with that, we'll add your PR on our dev-main branch.

Best,
Manu

Base automatically changed from master to main March 17, 2021 11:31
@einazare
Copy link
Contributor

This PR was closed since the modifications were not implemented - note, in a few days we'll release a new version of the product with the fix from here.

@einazare einazare closed this Mar 17, 2021
einazare added a commit that referenced this pull request Mar 18, 2021
Closes #4
Closes #5
Closes #6
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants