Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feat: Declined proof request reason #244

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Feat: Declined proof request reason #244

merged 2 commits into from
Dec 31, 2024

Conversation

tusharbhayani
Copy link
Contributor

Summary

UI added for declined proof request reason

Checklist before requesting a review

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this).
  • Self-review of code & No unnecessary commented-out code.
  • All existing functionality remain intact.
  • Updated the README if necessary..
  • No hard-coded sensitive information.

@tusharbhayani
feat: added declined proof request reason
4f4ce2f 
Signed-off-by: tusharbhayani <tushar.bhayani@ayanworks.com>
@tusharbhayani
refector: added string translation
534fc2e 
Signed-off-by: tusharbhayani <tushar.bhayani@ayanworks.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

amitpadmani-awts
amitpadmani-awts approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@amitpadmani-awts amitpadmani-awts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amitpadmani-awts amitpadmani-awts merged commit 733bd63 into develop Dec 31, 2024
7 of 8 checks passed
@amitpadmani-awts amitpadmani-awts deleted the feat/declined_proof_request_reason branch December 31, 2024 05:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@amitpadmani-awts amitpadmani-awts amitpadmani-awts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tusharbhayani @amitpadmani-awts