Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[FEATURE] modify files without pushing #80

Open
datapolitical opened this issue Dec 28, 2021 · 7 comments · Fixed by #122 or zaphiro-technologies/prettier_action#2
Open

[FEATURE] modify files without pushing #80

datapolitical opened this issue Dec 28, 2021 · 7 comments · Fixed by #122 or zaphiro-technologies/prettier_action#2
Labels
enhancement New feature or request hacktoberfest

Comments

@datapolitical
Copy link

datapolitical commented Dec 28, 2021

What would you like to change about the program?
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I would like to be able to modify files without pushing

Why do you think this is a cool idea?
A clear and concise description of why your feature would improve the program.

for people who already have a commit and push process as part of their action, it is unnecessary to have to push twice.

@datapolitical datapolitical added the enhancement New feature or request label Dec 28, 2021
@datapolitical datapolitical changed the title [FEATURE] [FEATURE] modify files without pushing Dec 28, 2021
@creyD
Copy link
Owner

creyD commented Dec 28, 2021

Sounds like a good idea!

@creyD
Copy link
Owner

creyD commented Dec 28, 2021

The dry parameter could be used for this behavior, right?

@datapolitical
Copy link
Author

With regard to dry mode, the documentation says "Runs the action in dry mode. Files wont get changed", which I took to mean that the files would not get modified.

@mauriciopasquier
Copy link

With regard to dry mode, the documentation says "Runs the action in dry mode. Files wont get changed", which I took to mean that the files would not get modified.

Same here. If dry mode works for this I think documentation could be reworded.

@ai-slave
Copy link

Dry run terminates the github action, just tested that.

@chicco785
Copy link

dry mode does not work because it detect not committed changes and fails

chicco785 added a commit to zaphiro-technologies/prettier_action that referenced this issue Jun 28, 2023
* Add support for an option called `dry_no_fail`
* Fixes creyD#80 in the original repository
@creyD
Copy link
Owner

creyD commented Jun 30, 2023

@chicco785 Do you think a custom commit_options with exclusion of everything would do the trick?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
5 participants