Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

pkg/ocicni: add PodAnnotations to RuntimeConfig #166

Merged
merged 1 commit into from
Jul 10, 2023
Merged

pkg/ocicni: add PodAnnotations to RuntimeConfig #166

merged 1 commit into from
Jul 10, 2023

Conversation

sohankunkerkar
Copy link
Member

@sohankunkerkar sohankunkerkar commented Jul 7, 2023 •
edited
Loading

related to cri-o/cri-o#7122

Support pod annotations CNI capabilities

@sohankunkerkar
pkg/ocicni: add PodAnnotations to RuntimeConfig
fdbe875 
related to cri-o/cri-o#7122

Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 7, 2023
@sohankunkerkar
Copy link
Member Author

/release-note-none

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 7, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2023
@saschagrunert
Copy link
Member

saschagrunert commented Jul 10, 2023 •
edited
Loading

@sohankunkerkar I guess we need a release note for that, right?

@sohankunkerkar
Copy link
Member Author

@sohankunkerkar I guess we need a release note for that, right?

Yeah, I agree

@sohankunkerkar
Copy link
Member Author

/release-note Support pod annotations CNI capabilities

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 10, 2023
saschagrunert
saschagrunert approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit eb8155a into cri-o:master Jul 10, 2023
@sohankunkerkar sohankunkerkar deleted the add-pod-annotations branch July 10, 2023 14:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@haircommander haircommander Awaiting requested review from haircommander

@rajatchopra rajatchopra Awaiting requested review from rajatchopra

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sohankunkerkar @saschagrunert @openshift-merge-robot