ocicni: pass a Pod UID down to CNI plugins as K8S_POD_UID #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dcbw: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
If a pod is deleted from the Kube API while a SetUpPod() call is ongoing it would be nice if the CNI plugin could easily figure that out and exit early. Plugins can watch the Kube API for pod events, but there is a race where the pod could have been deleted + recreated before the plugin is executed and sets up the watches. Since each new pod object will have a different UID, pass the UID we get from the runtime down to the CNI plugins so they can compare the UID they receive from ocicni with one they read from the Kube API. If the two UIDs are different, that means the pod was deleted + recreated before or during the plugin execution, and the plugin may wish to exit early since any information it read from the Kube API and used to configure sandbox resources may be out-of-date. Signed-off-by: Dan Williams <dcbw@redhat.com>
Pull Request Test Coverage Report for Build 927024188
💛 - Coveralls |
dcbw
force-pushed
the
pass-uid-to-plugins
branch
from
a75bfed to
1ea8db5
Compare
dcbw
removed
the
do-not-merge/release-note-label-needed
mccv1r0
reviewed
Jun 11, 2021
| Name string | ||
| // Namespace is the namespace of the sandbox. | ||
| // Namespace is the namespace of the pod. | ||
| Namespace string |
There was a problem hiding this comment.
Nit: Isn't Namespace still the name of the sandbox?
|
/lgtm |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a pod is deleted from the Kube API while a SetUpPod() call
is ongoing it would be nice if the CNI plugin could easily
figure that out and exit early. Plugins can watch the Kube API
for pod events, but there is a race where the pod could have
been deleted + recreated before the plugin is executed and
sets up the watches.
Since each new pod object will have a different UID, pass
the UID we get from the runtime down to the CNI plugins so
they can compare the UID they receive from ocicni with one
they read from the Kube API. If the two UIDs are different,
that means the pod was deleted + recreated before the plugin
ran, and the plugin may wish to exit early.
@trozet @mrunalp @mccv1r0