Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

more fixes to stac-model's readme #23

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

fmigneault
Copy link
Collaborator

Description

  • Releases badge were including the MLM specification instead of only stac-model-v... versions.
  • CI workflow was using an incorrect file
  • Using literal UTF-8 representation of the emojis, rather than GitHub :<name>: since they are not interpreted by PyPI

Related Issue

Follow up on #22

Type of Change

  • 📚 Examples, docs, tutorials or dependencies update;
  • 🔧 Bug fix (non-breaking change which fixes an issue);
  • 🥂 Improvement (non-breaking change which improves an existing feature);
  • 🚀 New feature (non-breaking change which adds functionality);
  • 💥 Breaking change (fix or feature that would cause existing functionality to change);
  • 🔐 Security fix.

Checklist

  • I've read the CONTRIBUTING.md guide;
  • I've updated the code style using make check;
  • I've written tests for all new methods and classes that I created;
  • I've written the docstring in Google format for all the methods and classes that I used.

@fmigneault fmigneault requested a review from rbavery May 13, 2024 17:13
@fmigneault fmigneault self-assigned this May 13, 2024
Copy link
Collaborator

@rbavery rbavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woohoo emojis! looks good.

@fmigneault fmigneault merged commit 602a274 into main May 14, 2024
8 checks passed
@fmigneault fmigneault deleted the fix-more-readme-stac-model branch May 14, 2024 19:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants