Skip to content
This repository has been archived by the owner on Mar 31, 2019. It is now read-only.

Evolve the CompositeActivity schema to accept multi-point edges #162

Closed
debbabi opened this issue Nov 23, 2017 · 4 comments
Closed

Evolve the CompositeActivity schema to accept multi-point edges #162

debbabi opened this issue Nov 23, 2017 · 4 comments
Milestone

Comments

@debbabi
Copy link
Member

debbabi commented Nov 23, 2017

Actual Edges of the CompositeActivity are simple direct lines between two points. E.g.:

screen shot 2017-11-23 at 10 14 34

It could be more elegant and practical to have a multi-point Edges between activities. E.g.:

screen shot 2017-11-23 at 09 45 35

Technically, we could add a vector of points (and their eventual metadata) to the DirectedEdge class, while we have to guarantee the compatibility with the previous schema.

E.g., see the new tag:

<NextDef ID="88" OriginVertexId="85" TerminusVertexId="84">
	<OriginPoint x="1900" y="400"/>
	<TerminusPoint x="1900" y="200”/>				
	<MultiPoints>
		<Point x=“..” y=“..” type=“..”/>
		<Point x=“..” y=“..” type=“..”/>
		<Point x=“..” y=“..” type=“..”/>
	</MultiPoints>
	<Properties>
		<KeyValuePair Key="Alias" String="true" isAbstract="false"/>
	</Properties>
</NextDef>

Next version of the GUI (or third-party visualization tools) could benefit from this new structure to show and/or edit the multi-point edges of the graph, or even have more sophisticated layouts.

@kovax
Copy link
Member

kovax commented Nov 24, 2017

Let's discuss it when we design the new LifecycleEditor. Actually I would rather separate the representation data from the actual LifeCycle semantic by storing it in a separate xml/json.

@kovax kovax added this to the Future work milestone Nov 24, 2017
@ogattaz
Copy link
Member

ogattaz commented Dec 30, 2017

In the future version 4, separating the representation data from the current Lyfecycle will be a big step forward.
The current demand is simply to be able to store optionnaly more informations in the wire definitions, to allow a third party editor to use them if needed.
The element "MultiPoints" has to be optionnal.
If the LifeCycle editor of the GUI client doesn't use it it's not an issue.

@ogattaz ogattaz modified the milestones: Future work, 3.4 Dec 30, 2017
@kovax kovax assigned debbabi and ogattaz and unassigned kovax, debbabi and ogattaz Dec 31, 2017
@kovax
Copy link
Member

kovax commented Dec 31, 2017

I deleted my previous comment, because I totally misinterpreted the request. This can be done. although I do not see the usefulness without changing the gui project. But if you submit a PR I will review and integrate it.

@kovax kovax modified the milestones: 3.4, Future work Dec 31, 2017
@ogattaz
Copy link
Member

ogattaz commented Jan 22, 2018

According the discussion during the 22/01/2018 meetting, tis issue is splited in three :
1 - addition of intermediate points in the wire ( this #162 issue) and validation with enhancements in the Gui client
2 - jpg or png rendering using the kernel graph package
3 - svg rendering

@kovax kovax closed this as completed Jun 24, 2018
@kovax kovax modified the milestones: Future work, 3.4 Jun 24, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

3 participants