Validate ssl peers #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, ssl peers where not validated unless custom certificate were provided. This led to less strict security and annoying warnings from em-http library. See igrigorik/em-http-request#339. Now we properly take tls_verify_peer option (defaults to true) in consideration. This should increase security. Change-Id: I3620aa3de63e20976a204be45bce013d816acc52
kamaradclimber
commented
Sep 2, 2021
| @@ -184,6 +184,7 @@ def _handle_error(http) | |||
|
|
|||
| def fetch | |||
| options = { | |||
| tls: { verify_peer: conf.tls_verify_peer }, | |||
There was a problem hiding this comment.
FAR: it would have been better to have a common base class for all endpoint types.
|
@PHBourquin have you had the time to test the PR? |
|
Thanks, could you ping me when you'll publish a new version to rubygems.org? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, ssl peers where not validated unless custom
certificate were provided. This led to less strict security and annoying
warnings from em-http library. See igrigorik/em-http-request#339.
Now we properly take tls_verify_peer option (defaults to true) in
consideration. This should increase security.
⚠ This is certainly a change for users who uses invalid certificate. However, the options
--skip-*-verify-tlsshould help them to explicitely disable validation if necessary.