Improve blocking tasks #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodas
force-pushed
the
feature/52-improve-blocking-tasks
branch
6 times, most recently
from
cffc42b to
c0285bc
Compare
crodas
force-pushed
the
feature/52-improve-blocking-tasks
branch
2 times, most recently
from
83e8aad to
c184baf
Compare
Introduce a generic way to spawn blocking tasks, adding an optional timeout option and a retry mechanism. The spawned task will subscribe to a set of keys and will be awaken everytime the data version changes in any of the watched keys. The worker function will return true or false, false meaning they want to be rescheduled again. This mechanism will improve CPU usage on current approach which is sleep/retry every few milliseconds, which is suboptimal to say the least.
crodas
force-pushed
the
feature/52-improve-blocking-tasks
branch
from
c184baf to
01307d3
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a generic way to spawn blocking tasks, adding an optional
timeout option and a retry mechanism.
The spawned task will subscribe to a set of keys and will be awaken
everytime the data version changes in any of the watched keys. The
worker function will return true or false, false meaning they want to be
rescheduled again.
This mechanism will improve CPU usage on current approach which is
sleep/retry every few milliseconds, which is suboptimal to say the
least.
Fixes #52