Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor Dockerfiles. #326

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Refactor Dockerfiles. #326

merged 1 commit into from
Oct 18, 2019

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Sep 24, 2019 •
edited
Loading

Common packages are now installed with common.sh.

Also fixes #330.

burrbull
burrbull previously approved these changes Sep 24, 2019
View reviewed changes
@reitermarkus reitermarkus force-pushed the refactoring branch 3 times, most recently from 39db7ec to 4598c1e Compare September 25, 2019 00:25
@reitermarkus reitermarkus requested review from a team and burrbull and removed request for jamesmunns September 25, 2019 02:13
@reitermarkus reitermarkus mentioned this pull request Sep 27, 2019
Closed
therealprof
therealprof previously approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Oct 17, 2019
@bors @reitermarkus
Merge #326
2c7bcd3 
326: Refactor Dockerfiles. r=therealprof a=reitermarkus

Common packages are now installed with `common.sh`.

Also fixes #330.

Co-authored-by: Markus Reiter <me@reitermark.us>
@bors
Copy link
Contributor

bors bot commented Oct 17, 2019

Build failed

  • rust-embedded.cross

@reitermarkus reitermarkus force-pushed the refactoring branch 2 times, most recently from 7b57d15 to 7e7bef3 Compare October 17, 2019 22:18
@reitermarkus
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Oct 18, 2019
@bors
Try #326:
8413309
@bors
Copy link
Contributor

bors bot commented Oct 18, 2019

try

Build succeeded

  • rust-embedded.cross

therealprof
therealprof approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Oct 18, 2019
@bors @reitermarkus
Merge #326
4fb4fc1 
326: Refactor Dockerfiles. r=therealprof a=reitermarkus

Common packages are now installed with `common.sh`.

Also fixes #330.

Co-authored-by: Markus Reiter <me@reitermark.us>
@bors
Copy link
Contributor

bors bot commented Oct 18, 2019

Build succeeded

  • rust-embedded.cross

@bors bors bot merged commit 3e11c60 into cross-rs:master Oct 18, 2019
@reitermarkus reitermarkus deleted the refactoring branch October 18, 2019 14:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@therealprof therealprof therealprof approved these changes

@Dylan-DPC-zz Dylan-DPC-zz Awaiting requested review from Dylan-DPC-zz

@burrbull burrbull Awaiting requested review from burrbull

@adamgreig adamgreig Awaiting requested review from adamgreig

@Disasm Disasm Awaiting requested review from Disasm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker build of armv7 image fails
3 participants
@reitermarkus @therealprof @burrbull