Prevent pkg-config from being removed in image #424
Merged
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| tar --strip-components 1 -xJ && \ | ||
| apt-get purge --auto-remove -y curl xz-utils | ||
| tar --strip-components 1 -xJ | ||
| # packages not removed since they were originally installed in common.sh |
There was a problem hiding this comment.
Maybe just remove the apt-get install line completely.
There was a problem hiding this comment.
Done in amended commit 843ad77.
jmagnuson
force-pushed
the
prevent-pkgconfig-purge
branch
from
7332551 to
843ad77
Compare
Currently, installing the toolchain for `arm-unknown-linux-gnueabihf` uses `xz-utils` which gets pruned. This also removes `pkg-config`, so remove the prune to keep both packages, and remove install since this is handled in `common.sh`. `curl` is similarly left as it was previously installed as well.
reitermarkus
approved these changes
May 16, 2020
|
bors r+ |
|
Build succeeded: |
|
Thanks, @jmagnuson! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, installing the toolchain for
arm-unknown-linux-gnueabihfuses
xz-utilswhich gets pruned. This also removespkg-config, soremove the prune altogether to keep both packages.
curlis also keptas that was originally installed in
common.shas well.Fixes #422