Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Minor bug fixes. #882

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Minor bug fixes. #882

merged 1 commit into from
Jun 29, 2022

Conversation

Alexhuszagh
Copy link
Contributor

Removes the requirement of an unused target from cross-util volumes remove and fixes the Ubuntu base testing.

@Alexhuszagh Alexhuszagh added the no changelog A valid PR without changelog (no-changelog) label Jun 29, 2022
@Alexhuszagh Alexhuszagh requested a review from a team as a code owner June 29, 2022 21:08
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically this is a breaking change due to removed required cli flag

@Alexhuszagh
Copy link
Contributor Author

Alexhuszagh commented Jun 29, 2022

technically this is a breaking change due to removed required cli flag

True, should we just make it optional then and ignore it? I can add a FIXME and say we remove it in 0.3.0.

@Emilgardis
Copy link
Member

sounds good, and hide it, we'll remove it in 0.3.0

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 29, 2022

Build succeeded:

@bors bors bot merged commit e583132 into cross-rs:main Jun 29, 2022
@Alexhuszagh Alexhuszagh deleted the minor_patches branch June 29, 2022 22:00
@Emilgardis Emilgardis added this to the v0.2.3 milestone Jul 1, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants