Exclude rawsocket entirely from browser builds #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may supersede the browser checks in |
oberstet
pushed a commit
that referenced
this pull request
Oct 11, 2015
Exclude rawsocket entirely from browser builds
|
Thanks for merging this. Would you be able to release this as v0.9.8? I'm currently pinned to v0.9.6 because of the build errors I get with webpack on v0.9.7 that this PR fixed, but would prefer to update all of my dependencies. |
|
@goeddea could you do a release please coming days? |
|
@ just released v0.9.8 |
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tells Browserify, webpack, &c. to completely skip
lib/transport/rawsocket.js.It also squelches an error in webpack for me, since webpack tries to statically handle all imports and chokes on the
netimport inrawsocket.js.