Support SLS logstore #77
Conversation
zzxwill
force-pushed
the
sls-logstore
branch
3 times, most recently
from
a715c4e to
71a2359
Compare
| region string | ||
| ) | ||
|
|
||
| switch { |
There was a problem hiding this comment.
It looks like this is being replicated in a number of controllers, might make sense to move it to a common package, such as client. crossplane-runtime also supports a common credentials extraction mechanism now that will allow you to fetch credentials from a variety of sources. Example here: https://github.com/crossplane/provider-aws/blob/3243f6c4cfa8c860ceee705c9eca72ea68398545/pkg/clients/aws.go#L105
Looks like there might need to be a crossplane-runtime update here first though so might make sense to tackle in a follow-up.
There was a problem hiding this comment.
I see this has already been implemented in #64, apologies for the delayed review there! I believe it needs a rebase but I will prioritize getting eyes on that!
apis/sls/v1alpha1/store_types.go
Outdated
| // SLS project name | ||
| // +kubebuilder:validation:MinLength:=3 | ||
| // +kubebuilder:validation:MaxLength:=63 | ||
| ProjectName string `json:"projectName"` |
There was a problem hiding this comment.
I believe you will want cross resource referencing implemented for this field to that folks are able to point to their Project resource in the cluster to populate the ProjectName. Let me know if you have any questions around implementation :)
There was a problem hiding this comment.
Correct. That's exactly what I need. I noticed a design doc on cross resource referencing https://github.com/crossplane/crossplane/blob/master/design/one-pager-cross-resource-referencing.md. A more straight example would be much appreciated.
There was a problem hiding this comment.
@hasheddan I thought it over. Resource SLS Store can also be independent of SLS Project. If the project doesn't exist, a ProjectNotExist error can occur https://www.alibabacloud.com/help/zh/doc-detail/29015.htm which is acceptable.
Implemented SLS logstore. To fix crossplane-contrib#67 Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
Co-authored-by: Daniel Mangum <31777345+hasheddan@users.noreply.github.com> Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
Co-authored-by: Daniel Mangum <31777345+hasheddan@users.noreply.github.com> Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
Co-authored-by: Daniel Mangum <31777345+hasheddan@users.noreply.github.com> Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
There was a problem hiding this comment.
@hasheddan Thanks dan, it's worked now, and let's refine in following PR. @zzxwill is also alibaba cloud staff and our community maintainer.
Description of your changes
Implemented SLS logstore.
Fixes #67
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Apply examples/sls/store.yaml