Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support CLB typed SLB #84

Merged
merged 3 commits into from
Jun 29, 2021
Merged

Support CLB typed SLB #84

merged 3 commits into from
Jun 29, 2021

Conversation

zzxwill
Copy link
Collaborator

@zzxwill zzxwill commented Jun 28, 2021

Supported provisioning of CLB instance

Signed-off-by: Zheng Xi Zhou zzxwill@gmail.com

Description of your changes

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

zzxwill added 2 commits June 28, 2021 21:26
Supported provisioning of CLB instance

Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
Copy link
Contributor

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonderflow wonderflow merged commit 3d563f8 into crossplane-contrib:master Jun 29, 2021
@zzxwill zzxwill deleted the clb branch June 29, 2021 09:52
@zzxwill zzxwill mentioned this pull request Jul 20, 2021
6 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants