Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use managed resource CLB name as "LoadBalancerName" #87

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Use managed resource CLB name as "LoadBalancerName" #87

merged 1 commit into from
Jul 1, 2021

Conversation

zzxwill
Copy link
Collaborator

@zzxwill zzxwill commented Jun 30, 2021

Description of your changes

Use managed resource CLB name as "LoadBalancerName"
And also fix nil issue

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@zzxwill
Use managed resource CLB name as "LoadBalancerName"
c40354d 
And also fix nil issue

Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
wonderflow
wonderflow approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonderflow wonderflow merged commit 1559ee3 into crossplane-contrib:master Jul 1, 2021
@zzxwill zzxwill mentioned this pull request Jul 20, 2021
Closed
6 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wonderflow wonderflow wonderflow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zzxwill @wonderflow