Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Print Columns for Subnet #253

Merged
merged 1 commit into from
May 28, 2021

Conversation

turkenh
Copy link
Collaborator

@turkenh turkenh commented May 28, 2021

Signed-off-by: Hasan Turken turkenh@gmail.com

Description of your changes

Subnet does not have a spec.location and ready/synced not available in get output.

This PR changes from:

NAME               STATE      LOCATION   AGE
conformancetest1   Updating              6m41s

To:

NAME               READY   SYNCED   STATE      AGE
conformancetest1   False   True     Updating   7m22s

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Create a subnet and run kubectl get.

Signed-off-by: Hasan Turken <turkenh@gmail.com>
@turkenh turkenh requested review from hasheddan and muvaf May 28, 2021 21:15
Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hasheddan hasheddan merged commit 81e5152 into crossplane-contrib:master May 28, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants