[release-0.11] Cherry pick docs fixes #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
region is required resource type for kind Provider of Alibaba Cloud or it will raise error message: error: the server doesn't have a resource type "region" Signed-off-by: zzxwill <zzxwill@gmail.com> (cherry picked from commit e11286b)
Followed provision infrasture to provision an RDSInstance CRD, it failed with the issue connect failed: cannot get provider secret: Secret "alibaba-creds" not found. By creating the secret in namespace `crossplane-system` will fix the issue Signed-off-by: zzxwill <zzxwill@gmail.com> (cherry picked from commit f3e19a7)
Changed Azure postgres version from 5.7 to 9.6 Signed-off-by: Zohaib Khan <zohaib.asghar.khan@gmail.com> Signed-off-by: zohaib.asghar.khan@gmail.com <zohaib.khan@swisscom.com> (cherry picked from commit 3eb55b0)
Changed Azure postgres version from 5.7 to 9.6 Signed-off-by: Zohaib Khan <zohaib.asghar.khan@gmail.com> Signed-off-by: zohaib.asghar.khan@gmail.com <zohaib.khan@swisscom.com> (cherry picked from commit cb8bbaf)
|
@jbw976 it looks like DCO had some trouble trying to parse the sign-off despite it working on the original PR. I can amend these commits or we can just set DCO to passing. Do you have a preference? I think I lean towards the latter so that these remain strict cherry picks. |
|
That sounds good @hasheddan, I examined the failing DCO parsing and the commit looks good to me with a human readable sign-off, so I have set the DCO check on this PR to pass now. |
jbw976
approved these changes
May 22, 2020
This was referenced May 22, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Cherry picks docs fixes from the following PRs:
#1560 (@zzxwill)
#1562 (@zzxwill)
#1564 (@Zee-Khan)
How has this code been tested?
[skip ci]
Checklist
I have:
make reviewableto ensure this PR is ready for review.appropriate.
For more about what we believe makes a pull request complete, see our
definition of done.