Use release v0.1.5 js-sdk #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mascot6699
commented
Nov 26, 2019
mascot6699
commented
- Use release v0.1.5 which gets rid of init function call before using other functions
- Combines all response handlers
govind1246
reviewed
Nov 26, 2019
| jsBridge.executeAsync(bridgeRequest); | ||
| } | ||
|
|
||
| public void putAddressMap(CruxAddressMapping newAddressMap, final CruxClientResponseHandler<CruxPutAddressMapSuccess> handler){ | ||
| public void putAddressMap(HashMap newAddressMap, final CruxClientResponseHandler<CruxPutAddressMapSuccess> handler){ |
There was a problem hiding this comment.
can we add HashMap<String, CruxAddress>?
govind1246
approved these changes
Nov 26, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.