Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(type): remove unused auth components and fix type-check #1316

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Jul 31, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-#stream/main


Related to #1181
Related to #1110

Description of the change:

  • Removed unused auth components.
  • Fixed type-check issue.

Motivation for the change:

See #1181

Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
@tthvo tthvo added chore Refactor, rename, cleanup, etc. safe-to-test labels Jul 31, 2024
@tthvo tthvo marked this pull request as ready for review July 31, 2024 18:29
@andrewazores andrewazores merged commit bbb0be0 into cryostatio:pf5 Jul 31, 2024
14 of 18 checks passed
@tthvo tthvo deleted the type-check-fix branch July 31, 2024 20:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants