chapters/hardware-software-interface: Add content for linking #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodutu
added
the
needs-rendering
github-actions
bot
added
area/tasks
victor1alexe
force-pushed
the
linking
branch
from
f06718c
to
6b07677
Compare
teodutu
added
needs-rendering
teodutu
requested changes
Sep 29, 2024
There was a problem hiding this comment.
The content looks great, good job! The inline suggestions I made are mostly small fixes. Don't worry about the linter failures, they are right, but the code is supposed to be wrong in those cases. In addition, please do the following:
- Add the this comment to all tasks'
README.mds: "If you're having difficulties solving this exercise, go through [this](link catre o sectiune relevanta din reading/) reading material." - Use C-style comments (
/* ... */) for SPDX identifiers in .h files. .c files are fine with//
...rdware-software-interface/linking/drills/tasks/single-link/support/diy/c-standalone/puts.asm
Outdated
Show resolved
Hide resolved
...re-software-interface/linking/drills/tasks/single-link/support/example/c-standalone/puts.asm
Outdated
Show resolved
Hide resolved
chapters/hardware-software-interface/linking/drills/tasks/cpp-obs/README.md
Outdated
Show resolved
Hide resolved
chapters/hardware-software-interface/linking/drills/tasks/vars-obs/README.md
Outdated
Show resolved
Hide resolved
victor1alexe
force-pushed
the
linking
branch
3 times, most recently
from
01ad898
to
abbf20f
Compare
Add Reading and Tasks. Modify config.yaml to render the laboratory. Signed-off-by: Victor Alexe <victor.alexe@stud.acs.upb.ro>
victor1alexe
force-pushed
the
linking
branch
from
abbf20f
to
5146107
Compare
teodutu
added
needs-rendering
teodutu
requested changes
Oct 4, 2024
| path: chapters/hardware-software-interface/linking/ | ||
| subsections: | ||
| - Reading/: reading/ | ||
| - Drills: |
There was a problem hiding this comment.
Add the "Gudies" subsection with cpp-obs.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Reading and Tasks.
Modify config.yaml to render the laboratory.
Prerequisite Checklist
Description of changes