Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix User_cleanup_Job #510

Merged
merged 4 commits into from
Mar 3, 2025
Merged

Fix User_cleanup_Job #510

merged 4 commits into from
Mar 3, 2025

Conversation

lodewiges
Copy link
Contributor

@lodewiges lodewiges commented Feb 20, 2025

fixes #428

The user archive job still failed due to restrictions in schema.rb so I. changed those to make an exception for the user with the id == 0. I also changed the model so when a form has been closed we can still archive the users response.

  • fix schema.rb

@lodewiges lodewiges marked this pull request as draft February 20, 2025 00:44
@lodewiges lodewiges changed the title Fix userArchiveJob Fix User_cleanup_Job Feb 20, 2025
@lodewiges lodewiges self-assigned this Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (488c3e8) to head (337a166).
Report is 1 commits behind head on staging.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging     #510   +/-   ##
========================================
  Coverage    99.92%   99.92%           
========================================
  Files          203      203           
  Lines         2769     2769           
========================================
  Hits          2767     2767           
  Misses           2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lodewiges lodewiges marked this pull request as ready for review February 20, 2025 21:32
@lodewiges lodewiges enabled auto-merge March 3, 2025 22:34
@lodewiges lodewiges disabled auto-merge March 3, 2025 22:34
@lodewiges lodewiges merged commit 7f63d81 into staging Mar 3, 2025
1 check passed
@lodewiges lodewiges deleted the fix/userArchiveJob branch March 3, 2025 22:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User_cleanup_Job doesn't run properly
1 participant