Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow to pass note play scheduling function #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pjagielski
Copy link

The current implementation of leipzig/live uses overtone/at to schedule playing a note, but this works only with OSC events. In my use case I want to schedule MIDI out events which uses Java MIDI API. I'm doing some research about the best options, for now I'm using overtone.at-at/at-at with fixed thread pool.

So in this PR I only make possible to pass own play-fn function to both leipzig.live/play and jam

@ctford
Copy link
Owner

ctford commented Jan 18, 2017

That's an interesting way to handle it. I came across a similar portability problem when using Leipzig from Javascript in Klangmeister. In my case I was a little lazier and just wrote a separate play function.

I'm a little undecided about what the best way to resolve the issue is. If possible, it could be nice to remove the dependency on Overtone altogether from Leipzig, which would substantially lower its transitive dependencies. On the other hand, your strategy of adding an extra arity is nicely backwards compatible and still gives Overtone users a nice default.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants