Fix type exports #364
Merged
Fix type exports #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the old type definitions, this was correct usage:
```js
// CJS
const MockAdapter = require('axios-mock-adapter');
const mock = new MockAdapter.default(/* … */)
```
```js
// ESM
const MockAdapter = require('axios-mock-adapter');
const mock = new MockAdapter.default(/* … */)
```
With the updated type definitions, this is:
```js
// CJS
const MockAdapter = require('axios-mock-adapter');
const mock = new MockAdapter(/* … */)
```
```js
// ESM
const MockAdapter = require('axios-mock-adapter');
const mock = new MockAdapter(/* … */)
```
This has always been an issue, but it has become more apparent with the
`"module": "node16"` option introduced in TypeScript 4.7.
marcbachmann
approved these changes
Mar 26, 2023
|
Sorry! I made an error! This is fixed in #368. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the old type definitions, this was correct usage:
With the updated type definitions, this is:
This has always been an issue, but it has become more apparent with the
"module": "node16"option introduced in TypeScript 4.7.