Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Test types #369

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Test types #369

merged 2 commits into from
Mar 27, 2023

Conversation

remcohaszing
Copy link
Contributor

@remcohaszing remcohaszing commented Mar 27, 2023 •
edited
Loading

Let’s make sure types are valid from now on. :)

Based on #368

@marcbachmann
Copy link
Collaborator

marcbachmann commented Mar 27, 2023 •
edited
Loading

There's also still #356 open. Does that look good to merge? 😄
So I'd merge the other first, this then fails if it's not correct.

@marcbachmann marcbachmann merged commit f2a65f6 into ctimmerm:master Mar 27, 2023
@marcbachmann
Copy link
Collaborator

Looks like type testing works. 😁 😅
3ccceaf broke it a bit.
Should we revert it as AxiosStatic just extends AxiosInstance:
https://github.com/axios/axios/blob/e7decef6a99f4627e27ed9ea5b00ce8e201c3841/index.d.ts#L523

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@marcbachmann marcbachmann marcbachmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remcohaszing @marcbachmann