Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update render_report.R to support quarto files #118

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

pbchase
Copy link
Contributor

@pbchase pbchase commented Jun 7, 2023

Addresses issues #117. This PR makes these changes:

  • Add quarto support.
  • Use argparse in render_report.R to provide better error handling. Add argparse package to Dockerfile.
  • Update docs to reflect the new feature.
  • Update example files to reflect a syntax change.

Note that I introduce a backward compatibility issue by changing the syntax of render_report.R it no longer accepts a parameter name and no longer prefixes the report names with report/. Instead, it wants only the path to the report and the path must be relative to the project root.

This change will not introduce chaos in CTS-IT systems, because this updated render_report.R is already deployed internally in the 3 projects that were using render_report.R It could introduce chaos at other sites, but it's not clear we have any users outside of CTS-IT.

Add quarto support.
Use argparse in render_report.R to provide better error handling.
Add argparse package to Dockerfile.
Update docs to reflect the new feature.
Update example files to reflect a syntax change.
@pbchase pbchase requested a review from ChemiKyle June 7, 2023 20:14
@pbchase pbchase marked this pull request as ready for review June 16, 2023 18:38
@ChemiKyle ChemiKyle merged commit abdfa12 into ctsit:develop Jun 21, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants