feat(snowflake-driver): Support execute sql via custom procedure #9579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| this.config.snowflakeExecutionProcedure && | ||
| query.toUpperCase().startsWith('SELECT') | ||
| ) { | ||
| const escapedQuery = query.replace(/'/g, "\\'"); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 days ago
To fix the issue, we need to ensure that backslashes in the query string are escaped before escaping single quotes. This can be achieved by first replacing all backslashes (\) with double backslashes (\\), and then replacing all single quotes (') with escaped single quotes (\'). This ensures that both backslashes and single quotes are properly escaped.
The best way to implement this fix is to chain two replace operations on the query string:
- Replace all backslashes (
\) with double backslashes (\\). - Replace all single quotes (
') with escaped single quotes (\').
This change should be applied to line 892 in the execute method.
Suggested changeset
1
packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts
| @@ -891,3 +891,3 @@ | ||
| ) { | ||
| const escapedQuery = query.replace(/'/g, "\\'"); | ||
| const escapedQuery = query.replace(/\\/g, "\\\\").replace(/'/g, "\\'"); | ||
| const serializedBinds = `ARRAY_CONSTRUCT(${(values ?? []) |
Copilot is powered by AI and may make mistakes. Always verify output.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.