Skip to content

Check code format on PR and main branch #268

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Conversation

ursfassler
Copy link
Contributor

@ursfassler ursfassler commented Dec 17, 2023

Summary

Check code format on PR and main branch.

Details

Make sure the code in the repo is correctly formatted by automatically checking the format on every PR.

Motivation and Context

Automatically keep the code format consistent.

How Has This Been Tested?

Pushed a commit (8977909) with a formatting error. CI fails.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to main, keeping only relevant commits.

@ursfassler ursfassler force-pushed the format branch 2 times, most recently from 8977909 to 3b71540 Compare December 17, 2023 21:24
@ursfassler ursfassler marked this pull request as ready for review December 18, 2023 20:49
@ursfassler ursfassler merged commit 8129e0a into cucumber:main Dec 18, 2023
@ursfassler ursfassler deleted the format branch December 18, 2023 20:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant