Skip to content

Commit

Permalink
[Build] Update versions
Browse files Browse the repository at this point in the history
  • Loading branch information
mpkorstanje committed Dec 14, 2020
1 parent dc8096e commit 028f017
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
## [Unreleased] (In Git)

### Added
* [JUnit Platform] Warn if feature files could not be found ([#2179](https://github.com/cucumber/cucumber-jvm/issues/2179) M.P. Korstanje)

### Changed

Expand All @@ -17,6 +16,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Removed

### Fixed
* [JUnit Platform] Warn if feature files could not be found ([#2179](https://github.com/cucumber/cucumber-jvm/issues/2179) M.P. Korstanje)
* [Core] SummaryPrinter outputs clickable links ([#2184](https://github.com/cucumber/cucumber-jvm/issues/2184) M.P. Korstanje)
* [Core] Merge duplicate plugin options ([#2190](https://github.com/cucumber/cucumber-jvm/issues/2190) M.P. Korstanje)

Expand Down
6 changes: 4 additions & 2 deletions core/src/main/java/io/cucumber/core/options/PluginOption.java
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,10 @@ boolean isSummaryPrinter() {

@Override
public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
if (this == o)
return true;
if (o == null || getClass() != o.getClass())
return false;
PluginOption that = (PluginOption) o;
return pluginClass.equals(that.pluginClass) && Objects.equals(argument, that.argument);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,8 @@ void throws_for_unknown_plugins() {
"PLUGIN can also be a fully qualified class name, allowing registration of 3rd party plugins. The 3rd party plugin must implement io.cucumber.plugin.Plugin"));
}


@Test
void should_implement_equals_and_hashcode(){
void should_implement_equals_and_hashcode() {
PluginOption prettyPluginA = PluginOption.forClass(PrettyFormatter.class);
PluginOption prettyPluginB = PluginOption.forClass(PrettyFormatter.class);
PluginOption htmlPluginA = PluginOption.forClass(HtmlFormatter.class, "out.html");
Expand Down
2 changes: 1 addition & 1 deletion examples/java-calculator-junit5/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<properties>
<project.Automatic-Module-Name>io.cucumber.examples.junit5</project.Automatic-Module-Name>
<jackson-databind.version>2.11.3</jackson-databind.version>
<jackson-databind.version>2.12.0</jackson-databind.version>
</properties>

<dependencies>
Expand Down
2 changes: 1 addition & 1 deletion examples/java-calculator/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<properties>
<project.Automatic-Module-Name>io.cucumber.examples.java</project.Automatic-Module-Name>
<jackson-databind.version>2.11.3</jackson-databind.version>
<jackson-databind.version>2.12.0</jackson-databind.version>
</properties>

<dependencies>
Expand Down
2 changes: 1 addition & 1 deletion examples/spring-txn/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<properties>
<project.Automatic-Module-Name>io.cucumber.examples.spring.txn</project.Automatic-Module-Name>
<spring-boot.version>2.3.5.RELEASE</spring-boot.version>
<spring-boot.version>2.4.1</spring-boot.version>
</properties>

<dependencyManagement>
Expand Down

0 comments on commit 028f017

Please # to comment.