Skip to content

JsonFormatter and JsonPrettyFormatter require Appendable, FormatterFactory uses File #232

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
hutchy2570 opened this issue Mar 1, 2012 · 3 comments
Closed

JsonFormatter and JsonPrettyFormatter require Appendable, FormatterFactory uses File #232

hutchy2570 opened this issue Mar 1, 2012 · 3 comments
Assignees
@aslakhellesoy
Milestone
1.0.0

Comments

@hutchy2570
Copy link
Contributor

RC20 uses Gherkin java 2.9.0 which contains JsonFormatter and JsonPrettyFormatter classes which only have a constructor with a single Appendable arg.

The FormatterFactory tries, if the out arg is a File, to construct these with a File arg and results in java.lang.NoSuchMethodException: gherkin.formatter.JSONPrettyFormatter.(java.io.File).

Previously if the out arg was a File, it would be wrapped in a FileWriter in the FormatterFactory before constructing the Formatter.
@aslakhellesoy
Copy link
Contributor

I'll be fixing this when I attack #160, #142 and #148 - it's long overdue!

@ghost ghost assigned aslakhellesoy Mar 1, 2012
hutchy2570 pushed a commit to lgi-kitd/cucumber-jvm that referenced this issue Mar 1, 2012
Fixed cucumber#232 & cucumber#221
89281a3 
Updated JUnitFormatter to use Appendable.
Updated FormatterFactory to wrap File in FileWriter
Updated FormatterFactory to create directories required for files
Updated FormatterFactory to add cucumber.monochrome flag to be passed to the Pretty & Progress formatters
aslakhellesoy added a commit that referenced this issue Mar 22, 2012
@aslakhellesoy
Understandable error message if a formatter needs output location. Cl…
2ea3787 
…oses #148, #232, #269.
@aslakhellesoy
Copy link
Contributor

This was fixed in 1.0.0.RC24

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@aslakhellesoy aslakhellesoy

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@aslakhellesoy @hutchy2570