Clean up public API #1223
Merged
Clean up public API #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mpkorstanje
changed the title
mpkorstanje
changed the title
TableConverter is not part of the public api but is used by DataTable. By extracting the interface we can hide the details of how a data table converts its data. This will also be usefull once we start moving away from xstream as we can introduce an XStreamTableConverter and SomeOtherTableConverter.
mpkorstanje
force-pushed
the
restore-and-depricate-testcase-public-api
branch
from
479b3b0 to
de46da5
Compare
brasmusson
added a commit
that referenced
this pull request
Sep 14, 2017
mpkorstanje
added a commit
that referenced
this pull request
Sep 14, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deprecate constructors and run methods of TestCase and TestStep and extract an interface for DataTable.
Details
Test(Case|Step) is exposed because it is part of the event bus protocol. However its constructors and run method have no general public use. As such they should not be part of the public api. In the long run Test(Case|Step) should be replaced with an interface.
TableConverter is not part of the public api but is used by DataTable.
By extracting the interface we can hide the details of how a data table
converts its data.
This will also be usefull once we start moving away from xstream as we
can introduce an XStreamTableConverter and SomeOtherTableConverter.
Motivation and Context
Keeping the public API neat, focused and clean will make it easier to maintain it in the future.