Skip to content

[Core] Json Formatter: include the content type of doc strings #1309

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 7, 2018

Conversation

brasmusson
Copy link
Contributor

Summary

Include the content type of a doc string in the Json Formatter output (if the content type of the doc string is defined in the feature file).

Details

The content type of the doc strings (if defined in the feature file) is not defined in the Pickles, so the Json Formatter need to fetch in based on the feature file AST.

Motivation and Context

In Cucumber-JVM v1.x.x the content type of doc strings were included in the Json Formatter output (if defined in the feature file).

How Has This Been Tested?

The automated test suite has been updated to verify this behavior.

Types of changes

  • Bug fix, regression from v1.x.x (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 81.48% when pulling 9b4498f on json-formatter-docstring-content-type into d3f85c0 on master.

@mpkorstanje mpkorstanje merged commit 0145029 into master Jan 7, 2018
@brasmusson brasmusson deleted the json-formatter-docstring-content-type branch January 7, 2018 18:09
brasmusson added a commit that referenced this pull request Jan 7, 2018
[CI SKIP]
@lock
Copy link

lock bot commented Jan 7, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 7, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants