Skip to content

-- replaced by # 267 -- #248

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

rplevy-draker
Copy link
Contributor

As we discussed in #244 (comment)
here are some changes to make it so that it is not necessary to specify a function, just the binding form of the implied function.

I also modified the Clojure tests to demonstrate the new syntax. The tests run successfully.


T E S T S

Running cucumber.runtime.clojure.ClojureSnippetTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.029 sec
Running cucumber.runtime.clojure.RunCukesTest

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.826 sec

Results :

Tests run: 4, Failures: 0, Errors: 0, Skipped: 0

[INFO] [jar:jar {execution: default-jar}]
[INFO] Preparing source:jar
[WARNING] Removing: jar from forked lifecycle, to prevent recursive invocation.
[INFO] [enforcer:enforce {execution: enforce-maven}]
[INFO] [source:jar {execution: bind-sources}]
[INFO] cucumber already added, skipping
[INFO] cucumber/runtime already added, skipping
[INFO] cucumber/runtime/clojure already added, skipping
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2 seconds
[INFO] Finished at: Thu Mar 08 11:58:04 EST 2012
[INFO] Final Memory: 31M/344M
[INFO] ------------------------------------------------------------------------

@aslakhellesoy
Copy link
Contributor

@rplevy-draker This no longer cleanly applies after @nilswloka contributed 47aaf2f

Can you update the pull-request please?

@rplevy-draker
Copy link
Contributor Author

Hi Aslak, I pushed a commit that fixes the conflict. Thanks, -Rob

@nilswloka
Copy link
Member

Just noticed that this will probably be obsolete if the clojure-native pull request is merged (#265). Macros for step definitions are defined in cucumber.backend.clj in the native version.

@aslakhellesoy
Copy link
Contributor

Yep, the native clojure backend (awesome!) makes this obsolete.

@aslakhellesoy
Copy link
Contributor

By obsolete I mean that the pull request no longer applies since #265 was merged. Of course I'd happily merge an updated pull request! Reopening this one.

@rplevy-draker
Copy link
Contributor Author

great! thank you.

@rplevy-draker
Copy link
Contributor Author

See #267. Sorry to have to do it as a separate request, but since I did it on a branch that's how it ended up working. This old issue can be closed. (closing it now).

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants