Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improved support for multiple classloaders in IncrementingUuidGenerator #2853

Merged

Conversation

jkronegg
Copy link
Contributor

@jkronegg jkronegg commented Feb 22, 2024

🤔 What's changed?

Corrected a test-case which fails rarely but sometimes.
Added possibility to give a specific classloader identifier.

⚡️ What's your motivation?

Fixes #2851

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)
  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

The comments in #2851 describe the problem and solution.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@jkronegg jkronegg changed the title fix: corrected classloader id collision for #2851 Improved support for multiple classloaders in IncrementingUuidGenerator Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.99%. Comparing base (c6c0ada) to head (d1261a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2853   +/-   ##
=========================================
  Coverage     84.99%   84.99%           
- Complexity     2733     2734    +1     
=========================================
  Files           331      331           
  Lines          9557     9559    +2     
  Branches        918      918           
=========================================
+ Hits           8123     8125    +2     
  Misses         1109     1109           
  Partials        325      325           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkronegg jkronegg requested a review from mpkorstanje February 23, 2024 07:33
@mpkorstanje mpkorstanje merged commit 0422d96 into main Mar 1, 2024
9 checks passed
@mpkorstanje mpkorstanje deleted the incrementing_uuid_generator_classloader_id_collision branch March 1, 2024 13:53
@mpkorstanje
Copy link
Contributor

Cheers!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IncrementingUuidGeneratorTest fails intermittently
2 participants