Test case for the PrettyFormatter #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test case for the PrettyFormatter to verify that the pretty formatter aligns the location strings correct, when a scenario is executed with Cucumber-JVM.
brasmusson
added a commit
to brasmusson/cucumber-jvm
that referenced
this pull request
Jul 14, 2013
Verify that the changes in PR cucumber#557 indeed fixes cucumber#491 and the other reports of that the PrettyFormatter is broken.
Now when cucumber-jvm has reveted to all-steps-first execution, the test case for the PrettyFormatter should pass.
brasmusson
added a commit
that referenced
this pull request
Jul 16, 2013
Merge pull request #544 Test case for the PrettyFormatter Update the History.md
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test case for the PrettyFormatter to verify that the pretty formatter aligns the location strings correct, when a scenario is executed with Cucumber-JVM.
This test case expose the well known IndexOutOfBoundsException in Cucumber-JVM 1.1.3. It also shows that when using the current snapshot of the Gherkin library (cucumber/gherkin@74bb687) the pretty formatter still does not align the location strings correctly.
The test case is something of an acceptance test for resolving the miss match between the expectations of the pretty formatter in the Gherkin libarary and the formatter call sequence in Cucumber-JVM.