Java style (camelcase) snippet generator option #561
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -196,4 +196,20 @@ public void set_strict_on_strict_aware_formatters() throws Exception { | |||
|
|
|||
| verify((StrictAware)strictAwareFormatter).setStrict(true); | |||
| } | |||
|
|
|||
| @Test | |||
| public void default_snippet_type() { | |||
There was a problem hiding this comment.
Can you give these tests an intent-revealing name please?
Clarifying test intention
| case CAMELCASE: | ||
| snippetGenerator = new CamelCaseSnippetGenerator(new JavaSnippet()); | ||
| break; | ||
| default: |
There was a problem hiding this comment.
Should be case UNDERSCORE.
default should throw CucumberException
Code review fixes
|
I believe I've incorporated all your suggestions |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
mpkorstanje
pushed a commit
that referenced
this pull request
Oct 4, 2019
mpkorstanje
pushed a commit
that referenced
this pull request
Oct 4, 2019
mpkorstanje
pushed a commit
that referenced
this pull request
Oct 4, 2019
mpkorstanje
pushed a commit
that referenced
this pull request
Oct 4, 2019
mpkorstanje
pushed a commit
that referenced
this pull request
Oct 4, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this discussion: #302 (comment)
Support for java style function names in snippets.
Configurable with --snippets in the cucumber.options. (junit and command line)
Values: underscore, camelcase
Default: underscore
Currently only supported by the JavaBackend