Handle "" properly in ListConverter. #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an empty string is passed it should return an empty list rather than a list of one empty string.
aslakhellesoy
added a commit
that referenced
this pull request
Aug 29, 2014
Handle "" properly in ListConverter.
|
Merci @cykl ! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an empty string is passed it should return an empty list rather than a list of one empty string.
I believe that the proposed behaviour is more useful than the current. The converter can be used to easily specify a variable number of arguments in a column. Users most likely want to be able to specify no elements at all.
Does this change sound reasonable ?
PS: I decided to return a new ArralyList rather than an empty collection from Collections because I expect that some users mutate the list in their Step def.