Make the Summary Printer into a plugin #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to load plugin classes by full class name on Jython the Thread.currentThread().contextClassLoader need to be set before calling cucumber.api.cli.Main
|
LGTM! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns the summary printing into a plugin, as discussed on the mailing list. Two built-in summary printer plugins are created,
default_summarywhich basically gives the same summary output as today, andnull_summarywhich gives no output at alInspired by Cucumber-Ruby, the
default_summaryis extended (compared to the current behaviour), with the listing of failed scenarios. Or to be precise the listing of the scenarios that makes the exit code non-zero, that is in strict mode also undefined and pending scenarios are listed.The different supported plugin types are separated into different categories internally, to be able to detect when to add default formatter. The current code is not entirely correct, if a StepDefinitionsReporter is added when the runtime options first is parsed (and not Formatter/Reporter plugin is also added), no Formatter/Reporter will exist during the execution.