Skip to content

Handle doc string and data tables in a single step #911

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed

Handle doc string and data tables in a single step #911

wants to merge 1 commit into from

Conversation

davidegrohmann
Copy link

No description provided.

@srbaker
Copy link

srbaker commented Sep 29, 2015

@aslakhellesoy can we get a merge on this? I want to make use of it. Thx.

@haroon-sheikh
Copy link
Contributor

@aslakhellesoy It would be really useful to get this merged in.

@brasmusson
Copy link
Contributor

As the new Gherkin parser (currently at version 4) does not support both a doc string and a data table in a single step, I truly believe that this should not be merged until it does. Otherwise it would block the upgrade from the outdated Gherkin v2.12.2 (#1035). As comparison Cucumber-Ruby upgraded from Gherkin v2.12.2 over a year ago.

@aslakhellesoy
Copy link
Contributor

I'm skeptical about allowing both doc strings and data tables in the same step. I don't think it encourages good documentation.

I might reconsider if someone can convince me with a real example.

@srbaker
Copy link

srbaker commented Aug 12, 2016

@aslakhellesoy Our use case is that the product is a database. It's admittedly a narrow group, not everyone is building a database, but we are and it makes sense for us. And the alternative is confusing and shitty. It'll really help us to get this in; please feel free to add "unless you're building a database, you probably don't want this." to documentation.

Other examples are over here: #867 (comment)

Thanks!

@aslakhellesoy
Copy link
Contributor

I added a comment over in #867. We'd need a Gherkin PR, make a Gherkin 5 release and update all the Cucumbers. I'm open for that if you submit the Gherkin PR.

@mpkorstanje
Copy link
Contributor

I'm closing this issue due to inactivity.

@mpkorstanje mpkorstanje closed this Jul 9, 2017
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants