Mod ConstantPoolTypeIntrospector to disregard closed variables #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new attempt at closing over local variables.
When the ConstantPoolTypeIntrospector looks at the static method which the lambda refers to, it disregards leading arguments which are used for passing in local state. By using the actual argument count in the AN (A1, A2 etc) interface, it can figure out how many argument types to look for.
This branch also contains dcowboys changes copy-pasted, since they were needed to make everything work on the latest JDK. Tell me how you would like to handle the merge of that if you would like to merge this request. Otherwise feel free to just take inspiration from my code and rewrite it as you wish.