Skip to content

Groovy: Fixed NPE when using List as parameter type in step definitions #980

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
May 11, 2016

Conversation

sjacobs
Copy link
Contributor

@sjacobs sjacobs commented Mar 31, 2016

To reproduce:

The following code caused a NullPointerException because ParameterInfo was initialized without default delimiter:

Given(~'^this should be converted to a list:(.+)$') { List list ->
    assertEquals(3, list.size())
    assertEquals("Cucumber-JVM", list.get(0))
    assertEquals("Cucumber", list.get(1))
}

The pull request contains the fix and the corresponding test.

@haroon-sheikh
Copy link
Contributor

Looks good to me.

@dkowis dkowis merged commit bfbae87 into cucumber:master May 11, 2016
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants