Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

C++ implementation #117

Closed
wants to merge 79 commits into from
Closed

C++ implementation #117

wants to merge 79 commits into from

Conversation

chybz
Copy link
Contributor

@chybz chybz commented May 31, 2023

🤔 What's changed?

  • Added C++ implementation

⚡️ What's your motivation?

  • Add native support for C++

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

  • was unable to check CI/CD behavior

📋 Checklist:


This text was originally generated from a template, then edited by hand. You can modify the template here.

@mpkorstanje mpkorstanje marked this pull request as draft June 2, 2023 14:03
@chybz chybz marked this pull request as ready for review June 2, 2023 14:06
@TheKayneGame
Copy link

Any Updates Regarding this PR?

@chybz
Copy link
Contributor Author

chybz commented Sep 13, 2023

@TheKayneGame apart from the minor conflicts in the two Markdown files that occurred recently, I couldn't merge this PR about 4 months ago when @mpkorstanje kindly gave me access (I also worked on the messages C++ implementation).
Could you please tell me what's missing ?

@TheKayneGame
Copy link

@chybz First of all thanks for the hard work.
The reason i ask this question is because this PR seems to have been open for all this time. and i was afraid it might have gone stale of something.

My main question is: Will this PR ever be merged?

@chybz
Copy link
Contributor Author

chybz commented Sep 13, 2023

That is indeed my only goal atm. Last time I tried, I was not allowed to do so.
I'll fix the small conflicts today and give it another go and keep you informed.

@chybz chybz closed this Sep 13, 2023
@chybz chybz deleted the feature/cpp branch September 13, 2023 15:25
@TheKayneGame
Copy link

Why has this been closed now?

@chybz
Copy link
Contributor Author

chybz commented Sep 13, 2023 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants