Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(deps): update dependency cucumber-messages to v24 #208

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

mpkorstanje
Copy link
Contributor

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje marked this pull request as ready for review January 4, 2024 14:59
@mpkorstanje mpkorstanje merged commit 9de4c7e into main Jan 4, 2024
@mpkorstanje mpkorstanje deleted the ruby-bump-messages branch January 4, 2024 14:59
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the versions given right?

@@ -20,7 +20,7 @@ Gem::Specification.new do |s|
'source_code_uri' => 'https://github.com/cucumber/gherkin/blob/main/ruby'
}

s.add_runtime_dependency 'cucumber-messages', '>= 19.1.4', '< 23'
s.add_runtime_dependency 'cucumber-messages', '>= 19.1.4', '< 24'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious: does this marker mean "use the gem less than 24", while the title of the PR is "update to v24"? What's the right value to use?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants