Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Korean dialect missing space after step keywords #254

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

kieran-ryan
Copy link
Member

@kieran-ryan kieran-ryan commented Jul 4, 2024

🤔 What's changed?

  • Added space between step keywords (Given, When, Then, And, But) for the Korean dialect

⚡️ What's your motivation?

image

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

NA.

📋 Checklist:

@kieran-ryan kieran-ryan added the 🐛 bug Defect / Bug label Jul 4, 2024
@kieran-ryan kieran-ryan self-assigned this Jul 4, 2024
@kieran-ryan kieran-ryan merged commit b6a7d4f into main Jul 4, 2024
32 checks passed
@kieran-ryan kieran-ryan deleted the fix/korean-keyword-space branch July 4, 2024 23:02
@mpkorstanje
Copy link
Contributor

@kieran-ryan I see the fixes are starting to pile up. Feel free to make a release!

@kieran-ryan
Copy link
Member Author

kieran-ryan commented Jul 15, 2024

@kieran-ryan I see the fixes are starting to pile up. Feel free to make a release!

Absolutely @mpkorstanje!

Happy with License file updates - including removal of old data; just want to double-check with you whether is good to go?

@mpkorstanje
Copy link
Contributor

Mmh. No, not quite.

@mpkorstanje
Copy link
Contributor

We'll release this after #259 otherwise we'll have another major right after this one.

@kieran-ryan
Copy link
Member Author

Perfect, makes sense @mpkorstanje - cheers!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🐛 bug Defect / Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants