Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed issue with empty feature file causing nil pointer deref #288

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

lonnblad
Copy link
Member

Fix for #286

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #288 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #288   +/-   ##
=======================================
  Coverage   84.91%   84.92%           
=======================================
  Files          16       16           
  Lines        2499     2500    +1     
=======================================
+ Hits         2122     2123    +1     
  Misses        259      259           
  Partials      118      118           
Impacted Files Coverage Δ
suite.go 87.95% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64ede2d...0c864f1. Read the comment docs.

@jamescooke
Copy link

Thanks for the quick fix - this looks like it fixes #286 for me locally 👍

@lonnblad lonnblad merged commit 8fb7cd9 into master Apr 30, 2020
@lonnblad lonnblad deleted the bugfix/empty-feature-nil-pointer branch June 13, 2020 09:01
@lonnblad lonnblad restored the bugfix/empty-feature-nil-pointer branch October 19, 2020 17:01
@mattwynne mattwynne deleted the bugfix/empty-feature-nil-pointer branch April 30, 2022 21:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants