Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added internal packages for formatters, storage and models #323

Merged
merged 1 commit into from
Jul 5, 2020

Conversation

lonnblad
Copy link
Member

@lonnblad lonnblad commented Jun 27, 2020

Created a formatters pkg for the exported formatter symbols:

func FindFmt(name string) FormatterFunc
func Format(name, description string, f FormatterFunc)
func AvailableFormatters() map[string]string
type Formatter interface
type FormatterFunc func(string, io.Writer) Formatter

Created an internal pkg for the:

  • all builtin formatters and the formatter-tests
  • all internal models
  • some shared internal utils

#319

@lonnblad lonnblad force-pushed the move-formatters-to-internal-pkg branch 2 times, most recently from e5e27bf to 932e07b Compare June 28, 2020 06:51
@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #323 into master will decrease coverage by 4.54%.
The diff coverage is 95.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   87.14%   82.59%   -4.55%     
==========================================
  Files          22       23       +1     
  Lines        2225     2218       -7     
==========================================
- Hits         1939     1832     -107     
- Misses        192      276      +84     
- Partials       94      110      +16     
Impacted Files Coverage Δ
flags.go 93.91% <ø> (ø)
internal/formatters/undefined_snippets_gen.go 42.55% <ø> (ø)
internal/formatters/fmt.go 76.31% <76.31%> (ø)
internal/formatters/fmt_base.go 86.33% <84.61%> (ø)
internal/models/results.go 92.30% <92.30%> (ø)
suite.go 90.41% <97.43%> (ø)
internal/formatters/fmt_events.go 97.47% <98.11%> (ø)
internal/formatters/fmt_pretty.go 81.22% <98.14%> (ø)
fmt.go 100.00% <100.00%> (ø)
formatters/fmt.go 100.00% <100.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28ad994...150c400. Read the comment docs.

@lonnblad lonnblad force-pushed the move-formatters-to-internal-pkg branch 8 times, most recently from a65b931 to a3f91cb Compare July 1, 2020 05:18
@lonnblad lonnblad changed the title Created internal packages for formatters, storage and models Added internal packages for formatters, storage and models Jul 2, 2020
@lonnblad lonnblad force-pushed the move-formatters-to-internal-pkg branch from a3f91cb to 150c400 Compare July 2, 2020 06:51
@lonnblad lonnblad merged commit 783f5e4 into master Jul 5, 2020
@mattwynne mattwynne deleted the move-formatters-to-internal-pkg branch April 30, 2022 21:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant