Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve ErrSkip handling, add test for Summary and operations order #584

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

vearutop
Copy link
Member

@vearutop vearutop commented Oct 27, 2023

🤔 What's changed?

This PR

  • Updates some of the error checks with errors.Is for better reliability with wrapping
  • Adds missing handling of step result statuses for ErrSkip
  • Adds a test to validate formatter Summary() and step execution flow

⚡️ What's your motivation?

#582 introduced a fix that was invisible for current test suite (tests passing before and after), while covering the fix with a regression test it turned out, ErrSkip is not properly reported in Summary().

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@github-actions
Copy link

Go API Changes

# summary
Inferred base version: v0.13.0
Suggested version: v0.13.1

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25274b0) 82.93% compared to head (85d342a) 83.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
+ Coverage   82.93%   83.22%   +0.28%     
==========================================
  Files          28       28              
  Lines        3411     3416       +5     
==========================================
+ Hits         2829     2843      +14     
+ Misses        467      458       -9     
  Partials      115      115              
Files Coverage Δ
suite.go 87.09% <100.00%> (+0.17%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vearutop vearutop marked this pull request as ready for review October 27, 2023 19:12
@vearutop vearutop merged commit 888fe3f into main Oct 29, 2023
@vearutop vearutop deleted the improve-skip branch October 29, 2023 21:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant