-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature/cpp #152
Feature/cpp #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers.
No external dependencies, so no JSON support as of now, hence no tests.
I think we can do without tests for serialization, but I would expect at the very least a test-cpp.yml
in the github workflows to ensure the project compiles.
Arbitrary dependency on C++20
I'm not familiar with CPP. Where does the dependency on C++20 come in to play?
You should not require the C++20 standard in the CMake file, POSSIBLE APPROACHES:
# -- FILE: CMakeLists.txt
# EXAMPLE FOR SOLUTION 1
if(NOT DEFINED CMAKE_CXX_STANDARD)
set(CMAKE_CXX_STANDARD 20) # Use C++20 standard as default
endif() |
Yes, definitely. That was just me being lazy. Thank you very much ! |
@mpkorstanje, @jenisys: repository should be in a decent state now, could you please comment on what I should do next ? (A bit more work is necessary for CI/CD). Thank you |
🤔 What's changed?
⚡️ What's your motivation?
While adding C++ support in Gherkin, saw that other implementations were using this repository, so decided to contribute in here as well.
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.